setup /v2/skaffoldLogs endpoint #5951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fold into skaffold-logs-endpoint
tejal29
approved these changes
Jun 4, 2021
Codecov Report
@@ Coverage Diff @@
## master #5951 +/- ##
==========================================
+ Coverage 70.57% 70.58% +0.01%
==========================================
Files 457 457
Lines 17531 17534 +3
==========================================
+ Hits 12372 12377 +5
- Misses 4244 4245 +1
+ Partials 915 912 -3
Continue to review full report at Codecov.
|
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Jun 7, 2021
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Jun 7, 2021
aaron-prindle
pushed a commit
to aaron-prindle/skaffold
that referenced
this pull request
Jun 7, 2021
This was referenced Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5368 #5370
Description
This PR adds the setup code for a new rpc/endpoint on the event API. This Endpoint doesn't do anything yet, but will be connected to the
SkaffoldLogEventmessages.User facing changes (remove if N/A)
Users can access this new endpoint, but it won't do anything.
Follow-up Work (remove if N/A)
Hookup this endpoint to
SkaffoldLogEventemission